SR-1232 [BT] SP-470 #close #time 1h #comment 공통컴포넌트 3.5.1 all-in-one 시큐어 코딩 패치 [RV]

closed on 12 Dec 17

[BT] SP-470 #close #time 1h #comment 공통컴포넌트 3.5.1 all-in-one 시큐어 코딩 패치 [RV]

Author

Moderator

Details
Objectives
General Comments 0 (0)
Number of files included: 44

jsTreeServiceFrameworkBackendAppRepo 0 (0)
- development-project/project-standard/standard-server/src/main 0 (0)
  - java/egovframework/com 0 (0)
    - cmm 0 (0)
      - service 0 (0)
        
        EgovFileMngUtil.java 0 (0) x
      - util 0 (0)
        
        EgovResourceCloseHelper.java 0 (0) x
      - AltibaseClobStringTypeHandler.java 0 (0) x
      - EgovWebUtil.java 0 (0) x
    - cop 0 (0)
      - adb/web 0 (0)
        
        EgovAdressBookController.java 0 (0) x
      - ems/web 0 (0)
        
        EgovSndngMailDetailController.java 0 (0) x
      - sms/service/impl 0 (0)
        
        EgovSmsBasicReceiver.java 0 (0) x
        
        EgovSmsInfoReceiver.java 0 (0) x
        
        SmsBasicDBUtil.java 0 (0) x
    - ext 0 (0)
      - jfile 0 (0)
        
        sample 0 (0)
        
        SampleFileUploadCluster.java 0 (0) x
        
        service/template 0 (0)
        
        JFileUploadModeTemplate.java 0 (0) x
      - ldapumt/service/impl 0 (0)
        
        DeptManageLdapDAO.java 0 (0) x
        
        ObjectMapper.java 0 (0) x
    - sym 0 (0)
      - bat/service 0 (0)
        
        BatchJobListener.java 0 (0) x
      - ccm 0 (0)
        
        acr/service/impl 0 (0)
        
        EgovAdministCodeRecptnServiceImpl.java 0 (0) x
        
        icr/service/impl 0 (0)
        
        EgovInsttCodeRecptnServiceImpl.java 0 (0) x
      - log/plg/service 0 (0)
        
        EgovPrivacyLogAspect.java 0 (0) x
      - mnu/mpm/service/impl 0 (0)
        
        EgovMenuManageServiceImpl.java 0 (0) x
      - sym/bak/service 0 (0)
        
        BackupJob.java 0 (0) x
        
        BackupJobListener.java 0 (0) x
    - uat/uap/filter 0 (0)
      - EgovLoginPolicyFilter.java 0 (0) x
    - uss/ion 0 (0)
      - bnr/service/impl 0 (0)
        
        EgovBannerServiceImpl.java 0 (0) x
      - lsi/service/impl 0 (0)
        
        EgovLoginScrinImageServiceImpl.java 0 (0) x
      - msi/service/impl 0 (0)
        
        EgovMainImageServiceImpl.java 0 (0) x
    - utl 0 (0)
      - fcc/service 0 (0)
        
        EgovFormBasedFileUtil.java 0 (0) x
        
        EgovStringUtil.java 0 (0) x
      - pao/web 0 (0)
        
        EgovErncslController.java 0 (0) x
      - sim/service 0 (0)
        
        EgovFileCmprs.java 0 (0) x
        
        EgovFileScrty.java 0 (0) x
        
        EgovFileTool.java 0 (0) x
        
        EgovPdfCnvr.java 0 (0) x
      - sys 0 (0)
        
        dbm/service 0 (0)
        
        DbMntrngChecker.java 0 (0) x
        
        fsm/service 0 (0)
        
        EgovFileSystemMntrngScheduling.java 0 (0) x
        
        FileSystemChecker.java 0 (0) x
        
        nsm/service 0 (0)
        
        NtwrkSvcMntrngChecker.java 0 (0) x
        
        srm/example 0 (0)
        
        EgovServerResrceMntrng.java 0 (0) x
        
        EgovServerResrceMntrngClient.java 0 (0) x
        
        ssy/service/impl 0 (0)
        
        EgovSynchrnServerServiceImpl.java 0 (0) x
        
        trm/web 0 (0)
        
        EgovTrsmrcvMntrngController.java 0 (0) x
      - wed/filter 0 (0)
        
        DefaultFileSaveManager.java 0 (0) x
  - resources/egovframework/sqlmap/com/sym/cal 0 (0)
    - EgovRestdeManage_SQL_Altibase.xml 0 (0) x
  - webapp/WEB-INF/jsp/egovframework/com/cop/smt 0 (0)
    - lsm 0 (0)
      - EgovLeaderSchdulDetail.jsp 0 (0) x
    - sdm 0 (0)
      - EgovDeptSchdulManageDetail.jsp 0 (0) x
    - sim 0 (0)
      - EgovIndvdlSchdulManageDetail.jsp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
admin	Author & Moderator	0m
Total		0m	0

Linked Issue:
SP-470

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

[BT] SP-470 #close #time 1h #comment 공통컴포넌트 3.5.1 all-in-one 시큐어 코딩 패치 [RV]

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/development-project/.../service/EgovFileMngUtil.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../util/EgovResourceCloseHelper.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../cmm/AltibaseClobStringTypeHandler.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../cmm/EgovWebUtil.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../web/EgovAdressBookController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../web/EgovSndngMailDetailController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovSmsBasicReceiver.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovSmsInfoReceiver.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/SmsBasicDBUtil.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../sample/SampleFileUploadCluster.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../template/JFileUploadModeTemplate.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/DeptManageLdapDAO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/ObjectMapper.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/BatchJobListener.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovAdministCodeRecptnServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovInsttCodeRecptnServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovPrivacyLogAspect.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovMenuManageServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/BackupJob.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/BackupJobListener.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../filter/EgovLoginPolicyFilter.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovBannerServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovLoginScrinImageServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovMainImageServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovFormBasedFileUtil.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovStringUtil.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../web/EgovErncslController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovFileCmprs.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovFileScrty.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovFileTool.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovPdfCnvr.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/DbMntrngChecker.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/EgovFileSystemMntrngScheduling.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/FileSystemChecker.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/NtwrkSvcMntrngChecker.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../example/EgovServerResrceMntrng.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../example/EgovServerResrceMntrngClient.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../impl/EgovSynchrnServerServiceImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../web/EgovTrsmrcvMntrngController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../filter/DefaultFileSaveManager.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../cal/EgovRestdeManage_SQL_Altibase.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../lsm/EgovLeaderSchdulDetail.jsp Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../sdm/EgovDeptSchdulManageDetail.jsp Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../sim/EgovIndvdlSchdulManageDetail.jsp Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-1232

[BT] SP-470 #close #time 1h #comment 공통컴포넌트 3.5.1 all-in-one 시큐어 코딩 패치 [RV]

SR-1232 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[BT] SP-470 #close #time 1h #comment 공통컴포넌트 3.5.1 all-in-one 시큐어 코딩 패치 [RV]

SR-1232 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against