SR-1234 [BT] SP-471 #close #time 1h #comment base push [RV]

closed on 12 Dec 17

[BT] SP-471 #close #time 1h #comment base push [RV]

Author

Moderator

Details
Objectives
General Comments 0 (0)
Number of files included: 36

jsTreeServiceFrameworkBackendAppRepo 0 (0)
- .idea 0 (0)
  - sonarIssues.xml 0 (0) x
- development-project/project-standard 0 (0)
  - standard-api-server 0 (0)
    - profiles/dev 0 (0)
      - database.properties 0 (0) x
    - src 0 (0)
      - main 0 (0)
        
        java/egovframework/com/ext/jstree/support/security 0 (0)
        
        controller 0 (0)
        
        PagesController.java 0 (0) x
        
        RegistrationController.java 0 (0) x
        
        database 0 (0)
        
        dao 0 (0)
        
        GenericDao.java 0 (0) x
        
        RoleDAO.java 0 (0) x
        
        UserDAO.java 0 (0) x
        
        model 0 (0)
        
        Role.java 0 (0) x
        
        User.java 0 (0) x
        
        dto 0 (0)
        
        LocalUser.java 0 (0) x
        
        SocialProvider.java 0 (0) x
        
        SocialUser.java 0 (0) x
        
        UserRegistrationForm.java 0 (0) x
        
        entrypoint 0 (0)
        
        AppAuthenticationEntryPoint.java 0 (0) x
        
        exception 0 (0)
        
        UserAlreadyExistAuthenticationException.java 0 (0) x
        
        handler 0 (0)
        
        AppSuccessHandler.java 0 (0) x
        
        registry 0 (0)
        
        AppConnectionSignUp.java 0 (0) x
        
        AppSocialAuthenticationServiceRegistry.java 0 (0) x
        
        service 0 (0)
        
        LocalUserDetailService.java 0 (0) x
        
        RegistrationUserDetailService.java 0 (0) x
        
        SocialUserDetailService.java 0 (0) x
        
        UserService.java 0 (0) x
        
        util 0 (0)
        
        SecurityUtil.java 0 (0) x
        
        webapp/WEB-INF 0 (0)
        
        spring-persistent-servlet.xml 0 (0) x
        
        spring-servlet.xml 0 (0) x
        
        web.xml 0 (0) x
      - test/java/database/demo 0 (0)
        
        SampleUsersDemo.java 0 (0) x
  - standard-server/src/main 0 (0)
    - resources/egovframework/spring/com 0 (0)
      - context-hibernate.xml 0 (0) x
    - webapp/WEB-INF 0 (0)
      - config/egovframework/springmvc 0 (0)
        
        egov-com-servlet.xml 0 (0) x
        
        egov-com-social.xml 0 (0) x
        
        egov-com-social.xml.bak 0 (0) x
      - jsp 0 (0)
        
        accessdenied.jsp 0 (0) x
        
        login.jsp 0 (0) x
        
        registration.jsp 0 (0) x
        
        user.jsp 0 (0) x
      - web.xml 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
admin	Author & Moderator	0m
Total		0m	0

Linked Issue:
SP-471

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

[BT] SP-471 #close #time 1h #comment base push [RV]

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/.idea/sonarIssues.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../dev/database.properties Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../controller/PagesController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../controller/RegistrationController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dao/GenericDao.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dao/RoleDAO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dao/UserDAO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../model/Role.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../model/User.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dto/LocalUser.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dto/SocialProvider.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dto/SocialUser.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../dto/UserRegistrationForm.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../entrypoint/AppAuthenticationEntryPoint.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../exception/UserAlreadyExistAuthenticationException.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../handler/AppSuccessHandler.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../registry/AppConnectionSignUp.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../registry/AppSocialAuthenticationServiceRegistry.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/LocalUserDetailService.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/RegistrationUserDetailService.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/SocialUserDetailService.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../service/UserService.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../util/SecurityUtil.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../WEB-INF/spring-persistent-servlet.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../WEB-INF/spring-servlet.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../WEB-INF/web.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../demo/SampleUsersDemo.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../com/context-hibernate.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../springmvc/egov-com-servlet.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/development-project/.../springmvc/egov-com-social.xml Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/development-project/.../springmvc/egov-com-social.xml.bak Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../jsp/accessdenied.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../jsp/login.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../jsp/registration.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../jsp/user.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/development-project/.../WEB-INF/web.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-1234

[BT] SP-471 #close #time 1h #comment base push [RV]

SR-1234 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[BT] SP-471 #close #time 1h #comment base push [RV]

SR-1234 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against