SR-1291 [BT] SP-474 #close #time 1h #comment simple is best [RV]

closed on 13 Dec 17

[BT] SP-474 #close #time 1h #comment simple is best [RV]

Author

Moderator

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
admin	Author & Moderator	0m
Total		0m	0

Linked Issue:
SP-474

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

[BT] SP-474 #close #time 1h #comment simple is best [RV]

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/.idea/artifacts/web_war_exploded.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_aop_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_aop_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_beans_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_beans_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_context_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_context_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_context_support_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_context_support_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_core_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_core_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_expression_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_expression_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_jdbc_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_jdbc_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_orm_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_orm_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_test_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_test_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_tx_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_tx_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_web_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_web_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_webmvc_4_1_9_RELEASE.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/.idea/libraries/Maven__org_springframework_spring_webmvc_4_3_9_RELEASE.xml Deleted FishEye View File History #permalink
Click to load diff

/.idea/sonarIssues.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/project/support/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/project/support/support.iml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../web/EgovArticleController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../web/EgovBBSMasterController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../com/context-datasource.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../bbs/EgovArticleRegist.jsp Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../bbs/EgovBBSMasterList.jsp Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/project/.../jstree/analyzeResult.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/web/.../ext/jstree/csrf.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../jstree/springDWRVersion.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../jstree/springHibernateVersion.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../jstree/springmyBatisVersion.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../jstree/strutsiBatisVersion.jsp Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/web/web.iml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-1291

[BT] SP-474 #close #time 1h #comment simple is best [RV]

SR-1291 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[BT] SP-474 #close #time 1h #comment simple is best [RV]

SR-1291 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against