SR-1297 [BT] SP-474 #close #time 1h #comment simple is best [RV]

closed on 13 Dec 17

[BT] SP-474 #close #time 1h #comment simple is best [RV]

Author

Moderator

Details
Objectives
General Comments 0 (0)
Number of files included: 22

jsTreeServiceFrameworkBackendAppRepo 0 (0)
- .idea 0 (0)
  - sonarIssues.xml 0 (0) x
- standard/project/web/src/main 0 (0)
  - java/egovframework/com/ext/jstree 0 (0)
    - springHibernate/core 0 (0)
      - controller 0 (0)
        
        JsTreeHibernateController.java 0 (0) x
      - dao 0 (0)
        
        JsTreeHibernateAbstractDao.java 0 (0) x
        
        JsTreeHibernateDao.java 0 (0) x
        
        JsTreeHibernateDaoImpl.java 0 (0) x
      - service 0 (0)
        
        JsTreeHibernateService.java 0 (0) x
        
        JsTreeHibernateServiceImpl.java 0 (0) x
      - vo 0 (0)
        
        JsTreeHibernateBaseDTO.java 0 (0) x
        
        JsTreeHibernateDTO.java 0 (0) x
        
        JsTreeHibernatePaginatedDTO.java 0 (0) x
        
        JsTreeHibernateSearchDTO.java 0 (0) x
    - support 0 (0)
      - mvc 0 (0)
        
        GenericAbstractController.java 0 (0) x
        
        RequestAttribute.java 0 (0) x
      - util 0 (0)
        
        DateUtils.java 0 (0) x
        
        MessageSupport.java 0 (0) x
        
        ParameterParser.java 0 (0) x
        
        ScheduleUtil.java 0 (0) x
        
        StringUtils.java 0 (0) x
        
        Text.java 0 (0) x
    - package-info.java 0 (0) x
  - webapp/WEB-INF 0 (0)
    - config/egovframework/springmvc 0 (0)
      - egov-com-servlet.xml 0 (0) x
    - jsp/egovframework/com/ext/jstree 0 (0)
      - springHibernateVersion.jsp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
admin	Author & Moderator
Total		0m	0

Linked Issue:
SP-474

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

[BT] SP-474 #close #time 1h #comment simple is best [RV]

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/.idea/sonarIssues.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../controller/JsTreeHibernateController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../dao/JsTreeHibernateAbstractDao.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../dao/JsTreeHibernateDao.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../dao/JsTreeHibernateDaoImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../service/JsTreeHibernateService.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../service/JsTreeHibernateServiceImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../vo/JsTreeHibernateBaseDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../vo/JsTreeHibernateDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../vo/JsTreeHibernatePaginatedDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../vo/JsTreeHibernateSearchDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../mvc/GenericAbstractController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../mvc/RequestAttribute.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/.../util/DateUtils.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/.../util/MessageSupport.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../util/ParameterParser.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/.../util/ScheduleUtil.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/.../util/StringUtils.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/.../support/util/Text.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/project/.../jstree/package-info.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/standard/.../springmvc/egov-com-servlet.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/standard/.../jstree/springHibernateVersion.jsp Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-1297

[BT] SP-474 #close #time 1h #comment simple is best [RV]

SR-1297 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[BT] SP-474 #close #time 1h #comment simple is best [RV]

SR-1297 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against