SR-1778 [ jsTree Service Framework(TSF) rollback validation] [SmartCommit] SP-548 #close #time 1h

closed on 27 Jul 19

[ jsTree Service Framework(TSF) rollback validation] [SmartCommit] SP-548 #close #time 1h

Author

Moderator

Reviewers

Details
Objectives
General Comments 0 (0)
Number of files included: 58

jsTreeServiceFrameworkCoreLibRepo 0 (0)
- core-module 0 (0)
  - src/main 0 (0)
    - java/egovframework/com/ext/jstree 0 (0)
      - springHibernate/core 0 (0)
        
        controller 0 (0)
        
        JsTreeHibernateController.java 0 (0) x
        
        validation 0 (0)
        
        custom 0 (0)
        
        constraints 0 (0)
        
        Contained.java 0 (0) x
        
        validator 0 (0)
        
        ContainedValidator.java 0 (0) x
        
        group 0 (0)
        
        AddNode.java 0 (0) x
        
        AlterNode.java 0 (0) x
        
        AlterNodeType.java 0 (0) x
        
        GetChildNode.java 0 (0) x
        
        MoveNode.java 0 (0) x
        
        RemoveNode.java 0 (0) x
        
        SearchNode.java 0 (0) x
      - springiBatis/core 0 (0)
        
        controller 0 (0)
        
        CoreController.java 0 (0) x
        
        validation 0 (0)
        
        custom 0 (0)
        
        constraints 0 (0)
        
        Contained.java 0 (0) x
        
        validator 0 (0)
        
        ContainedValidator.java 0 (0) x
        
        group 0 (0)
        
        AddNode.java 0 (0) x
        
        AlterNode.java 0 (0) x
        
        AlterNodeType.java 0 (0) x
        
        GetChildNode.java 0 (0) x
        
        MoveNode.java 0 (0) x
        
        RemoveNode.java 0 (0) x
        
        SearchNode.java 0 (0) x
      - strutsiBatis/core 0 (0)
        
        dao 0 (0)
        
        I_DB_GetChildNode.java 0 (0) x
        
        I_DB_GetNode.java 0 (0) x
        
        I_DB_SearchNode.java 0 (0) x
        
        service 0 (0)
        
        I_S_GetChildNode.java 0 (0) x
      - support/security 0 (0)
        
        controller 0 (0)
        
        RegistrationController.java 0 (0) x
        
        database/model 0 (0)
        
        User.java 0 (0) x
        
        dto 0 (0)
        
        UserRegistrationForm.java 0 (0) x
        
        service 0 (0)
        
        RegistrationUserDetailService.java 0 (0) x
    - resources/egovframework 0 (0)
      - message/com/bbs 0 (0)
        
        message_en.properties 0 (0) x
        
        message_ko.properties 0 (0) x
      - spring/com 0 (0)
        
        context-validator.xml 0 (0) x
      - validator 0 (0)
        
        com/cop 0 (0)
        
        adb 0 (0)
        
        EgovAdressBook.xml 0 (0) x
        
        bbs 0 (0)
        
        EgovBdMstrRegist.xml.org 0 (0) x
        
        EgovCommentRegist.xml 0 (0) x
        
        EgovNoticeRegist.xml 0 (0) x
        
        EgovSatisfactionRegist.xml 0 (0) x
        
        EgovScrapRegist.xml 0 (0) x
        
        clb 0 (0)
        
        EgovClubRegist.xml 0 (0) x
        
        cmy 0 (0)
        
        EgovCmmntyRegist.xml 0 (0) x
        
        com 0 (0)
        
        EgovCopComManage.xml 0 (0) x
        
        ems 0 (0)
        
        EgovMailRegist.xml 0 (0) x
        
        ncm 0 (0)
        
        EgovNcrdRegist.xml 0 (0) x
        
        sms 0 (0)
        
        EgovSmsInfoRegist.xml 0 (0) x
        
        smt 0 (0)
        
        djm 0 (0)
        
        EgovDeptJob.xml 0 (0) x
        
        EgovDeptJobBx.xml 0 (0) x
        
        dsm 0 (0)
        
        EgovDiaryManage.xml 0 (0) x
        
        lsm 0 (0)
        
        EgovLeaderSchdul.xml 0 (0) x
        
        EgovLeaderSttus.xml 0 (0) x
        
        mrm 0 (0)
        
        EgovMemoReprt.xml 0 (0) x
        
        mtm 0 (0)
        
        EgovMemoTodo.xml 0 (0) x
        
        sdm 0 (0)
        
        EgovDeptSchdulManage.xml 0 (0) x
        
        sim 0 (0)
        
        EgovIndvdlSchdulManage.xml 0 (0) x
        
        wmr 0 (0)
        
        EgovWikMnthngReprt.xml 0 (0) x
        
        com-rules.xml 0 (0) x
        
        validator-rules.xml 0 (0) x
  - pom.xml 0 (0) x
- lib-module 0 (0)
  - pom.xml 0 (0) x
- pom.xml 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
admin	Author & Moderator
dongmin.lee	Reviewer - 0% reviewed
Total		0m	0

Linked Issue:
SP-548

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

[ jsTree Service Framework(TSF) rollback validation]
[SmartCommit] SP-548 #close #time 1h

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/core-module/.../controller/JsTreeHibernateController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../constraints/Contained.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/.../validator/ContainedValidator.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/AddNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/AlterNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/AlterNodeType.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/GetChildNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/MoveNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/RemoveNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/SearchNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/.../controller/CoreController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../constraints/Contained.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/.../validator/ContainedValidator.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/AddNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/AlterNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/AlterNodeType.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/GetChildNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/MoveNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/RemoveNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../group/SearchNode.java Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/.../dao/I_DB_GetChildNode.java Changed FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../dao/I_DB_GetNode.java Changed FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../dao/I_DB_SearchNode.java Changed FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/.../service/I_S_GetChildNode.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../controller/RegistrationController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../database/model/User.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../dto/UserRegistrationForm.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../service/RegistrationUserDetailService.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../bbs/message_en.properties Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../bbs/message_ko.properties Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../com/context-validator.xml Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/src/.../adb/EgovAdressBook.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../bbs/EgovBdMstrRegist.xml.org Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../bbs/EgovCommentRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../bbs/EgovNoticeRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../bbs/EgovSatisfactionRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../bbs/EgovScrapRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../clb/EgovClubRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../cmy/EgovCmmntyRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../com/EgovCopComManage.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../ems/EgovMailRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../ncm/EgovNcrdRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../sms/EgovSmsInfoRegist.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../smt/djm/EgovDeptJob.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../smt/djm/EgovDeptJobBx.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../dsm/EgovDiaryManage.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../lsm/EgovLeaderSchdul.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../lsm/EgovLeaderSttus.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../smt/mrm/EgovMemoReprt.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../smt/mtm/EgovMemoTodo.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../sdm/EgovDeptSchdulManage.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../sim/EgovIndvdlSchdulManage.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/.../wmr/EgovWikMnthngReprt.xml Added FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/core-module/src/.../validator/com-rules.xml Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/.../validator/validator-rules.xml Added FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/core-module/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/lib-module/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-1778

[ jsTree Service Framework(TSF) rollback validation] [SmartCommit] SP-548 #close #time 1h

SR-1778 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[ jsTree Service Framework(TSF) rollback validation] [SmartCommit] SP-548 #close #time 1h

SR-1778 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against