SR-3365 [SP-313] #comment DSL 을 이용하여 pdservice, pdjira, pdversion 모듈 개발 및 버전업 #close #time 1h

open for 30 months | due 30 months ago

[SP-313] #comment DSL 을 이용하여 pdservice, pdjira, pdversion 모듈 개발 및 버전업 #close #time 1h

Author

Moderator

Reviewers

Details
Objectives
General Comments 0 (0)
Number of files included: 48

jsTreeServiceFrameworkBackendAppRepo 0 (0)
- web-module 0 (0)
  - script/ddl/oracle/egovframework/api 0 (0)
    - Arms_PdVersionService_DDL_Oracle.sql 0 (0) x
  - src/main 0 (0)
    - java/egovframework/api/arms 0 (0)
      - module_pdjira 0 (0)
        
        controller 0 (0)
        
        AdminPdJiraController.java 0 (0) x
        
        AnonPdJiraController.java 0 (0) x
        
        UserPdJiraController.java 0 (0) x
        
        model 0 (0)
        
        PdJiraDTO.java 0 (0) x
        
        service 0 (0)
        
        PdJira.java 0 (0) x
        
        PdJiraImpl.java 0 (0) x
      - module_pdservice 0 (0)
        
        controller 0 (0)
        
        AdminPdServiceController.java 0 (0) x
        
        AnonPdServiceController.java 0 (0) x
        
        UserPdServiceController.java 0 (0) x
        
        model 0 (0)
        
        PdServiceDTO.java 0 (0) x
        
        service 0 (0)
        
        PdService.java 0 (0) x
        
        PdServiceImpl.java 0 (0) x
      - module_pdversion 0 (0)
        
        controller 0 (0)
        
        AdminPdVersionController.java 0 (0) x
        
        AnonPdVersionController.java 0 (0) x
        
        UserPdVersionController.java 0 (0) x
        
        model 0 (0)
        
        PdVersionDTO.java 0 (0) x
        
        service 0 (0)
        
        PdVersion.java 0 (0) x
        
        PdVersionImpl.java 0 (0) x
      - pdService 0 (0)
        
        controller 0 (0)
        
        AdminPdServiceController.java 0 (0) x
        
        AnonPdServiceController.java 0 (0) x
        
        UserPdServiceController.java 0 (0) x
        
        model 0 (0)
        
        PdServiceDTO.java 0 (0) x
        
        PdServiceVO.java 0 (0) x
        
        service 0 (0)
        
        PdService.java 0 (0) x
        
        PdServiceImpl.java 0 (0) x
      - pdServiceJira 0 (0)
        
        controller 0 (0)
        
        AdminPdServiceJiraController.java 0 (0) x
        
        AnonPdServiceJiraController.java 0 (0) x
        
        UserPdServiceJiraController.java 0 (0) x
        
        model 0 (0)
        
        PdServiceJiraDTO.java 0 (0) x
        
        PdServiceJiraVO.java 0 (0) x
        
        service 0 (0)
        
        PdServiceJira.java 0 (0) x
        
        PdServiceJiraImpl.java 0 (0) x
      - pdVersionService 0 (0)
        
        controller 0 (0)
        
        AdminPdVersionServiceController.java 0 (0) x
        
        AnonPdVersionServiceController.java 0 (0) x
        
        UserPdVersionServiceController.java 0 (0) x
        
        model 0 (0)
        
        PdVersionServiceDTO.java 0 (0) x
        
        PdVersionServiceVO.java 0 (0) x
        
        service 0 (0)
        
        PdVersionService.java 0 (0) x
        
        PdVersionServiceImpl.java 0 (0) x
    - resources/script 0 (0)
      - ddl/oracle/arms 0 (0)
        
        PdJira_Oracle_DDL.sql 0 (0) x
        
        PdService_Oracle_DDL.sql 0 (0) x
        
        PdVersion_Oracle_DDL.sql 0 (0) x
      - dml/oracle/arms 0 (0)
        
        PdJira_Oracle_DML.sql 0 (0) x
        
        PdService_Oracle_DML.sql 0 (0) x
        
        PdVersion_Oracle_DML.sql 0 (0) x
  - pom.xml 0 (0) x
- pom.xml 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
admin	Author & Moderator
dongmin.lee	Reviewer - 0% reviewed
Total		0m	0

Linked Issue:
SP-313

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

SP-313 #comment DSL 을 이용하여 pdservice, pdjira, pdversion 모듈 개발 및 버전업 #close #time 1h

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/web-module/.../api/Arms_PdVersionService_DDL_Oracle.sql Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminPdJiraController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AnonPdJiraController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/UserPdJiraController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../model/PdJiraDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/PdJira.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/PdJiraImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminPdServiceController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AnonPdServiceController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/UserPdServiceController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../model/PdServiceDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/PdService.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/PdServiceImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminPdVersionController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AnonPdVersionController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/UserPdVersionController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../model/PdVersionDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/PdVersion.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/PdVersionImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminPdServiceController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonPdServiceController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserPdServiceController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/PdServiceDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/PdServiceVO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/PdService.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/PdServiceImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminPdServiceJiraController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonPdServiceJiraController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserPdServiceJiraController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../model/PdServiceJiraDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/PdServiceJiraVO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/PdServiceJira.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/PdServiceJiraImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminPdVersionServiceController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonPdVersionServiceController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserPdVersionServiceController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../model/PdVersionServiceDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../model/PdVersionServiceVO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/PdVersionService.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/PdVersionServiceImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../arms/PdJira_Oracle_DDL.sql Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../arms/PdService_Oracle_DDL.sql Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../arms/PdVersion_Oracle_DDL.sql Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../arms/PdJira_Oracle_DML.sql Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../arms/PdService_Oracle_DML.sql Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../arms/PdVersion_Oracle_DML.sql Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-3365

[SP-313] #comment DSL 을 이용하여 pdservice, pdjira, pdversion 모듈 개발 및 버전업 #close #time 1h

SR-3365 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[SP-313] #comment DSL 을 이용하여 pdservice, pdjira, pdversion 모듈 개발 및 버전업 #close #time 1h

SR-3365 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against