SR-3549 [SP-313] #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.10 1. 쓸데없는 모듈 클래스 삭제 2. 신규 버전 등록 시에 베이스 버전과 함께...

open for 19 months | due 19 months ago

[SP-313] #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.10 1. 쓸데없는 모듈 클래스 삭제 2. 신규 버전 등록 시에 베이스 버전과 함께...

Author

Moderator

Reviewers

Details
Objectives
General Comments 0 (0)
Number of files included: 75

jsTreeServiceFrameworkBackendAppRepo 0 (0)
- web-module 0 (0)
  - src/main 0 (0)
    - java/egovframework/api/arms 0 (0)
      - module_analcrawler 0 (0)
        
        controller 0 (0)
        
        AdminAnalCrawlerController.java 0 (0) x
        
        AnonAnalCrawlerController.java 0 (0) x
        
        UserAnalCrawlerController.java 0 (0) x
        
        model 0 (0)
        
        AnalCrawlerDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalCrawler.java 0 (0) x
        
        AnalCrawlerImpl.java 0 (0) x
      - module_analpdheatmap 0 (0)
        
        controller 0 (0)
        
        AdminAnalPdHeatmapController.java 0 (0) x
        
        AnonAnalPdHeatmapController.java 0 (0) x
        
        UserAnalPdHeatmapController.java 0 (0) x
        
        model 0 (0)
        
        AnalPdHeatmapDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalPdHeatmap.java 0 (0) x
        
        AnalPdHeatmapImpl.java 0 (0) x
      - module_analpdmember 0 (0)
        
        controller 0 (0)
        
        AdminAnalPdMemberController.java 0 (0) x
        
        AnonAnalPdMemberController.java 0 (0) x
        
        UserAnalPdMemberController.java 0 (0) x
        
        model 0 (0)
        
        AnalPdMemberDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalPdMember.java 0 (0) x
        
        AnalPdMemberImpl.java 0 (0) x
      - module_analpdrelease 0 (0)
        
        controller 0 (0)
        
        AdminAnalPdReleaseController.java 0 (0) x
        
        AnonAnalPdReleaseController.java 0 (0) x
        
        UserAnalPdReleaseController.java 0 (0) x
        
        model 0 (0)
        
        AnalPdReleaseDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalPdRelease.java 0 (0) x
        
        AnalPdReleaseImpl.java 0 (0) x
      - module_analreport 0 (0)
        
        controller 0 (0)
        
        AdminAnalReportController.java 0 (0) x
        
        AnonAnalReportController.java 0 (0) x
        
        UserAnalReportController.java 0 (0) x
        
        model 0 (0)
        
        AnalReportDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalReport.java 0 (0) x
        
        AnalReportImpl.java 0 (0) x
      - module_analreqjira 0 (0)
        
        controller 0 (0)
        
        AdminAnalReqJiraController.java 0 (0) x
        
        AnonAnalReqJiraController.java 0 (0) x
        
        UserAnalReqJiraController.java 0 (0) x
        
        model 0 (0)
        
        AnalReqJiraDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalReqJira.java 0 (0) x
        
        AnalReqJiraImpl.java 0 (0) x
      - module_analreqrole 0 (0)
        
        controller 0 (0)
        
        AdminAnalReqRoleController.java 0 (0) x
        
        AnonAnalReqRoleController.java 0 (0) x
        
        UserAnalReqRoleController.java 0 (0) x
        
        model 0 (0)
        
        AnalReqRoleDTO.java 0 (0) x
        
        service 0 (0)
        
        AnalReqRole.java 0 (0) x
        
        AnalReqRoleImpl.java 0 (0) x
      - module_pdservice/controller 0 (0)
        
        UserPdServiceController.java 0 (0) x
      - module_reqadd 0 (0)
        
        controller 0 (0)
        
        AdminReqAddController.java 0 (0) x
        
        AnonReqAddController.java 0 (0) x
        
        UserReqAddController.java 0 (0) x
        
        dao 0 (0)
        
        ReqAddSqlMapperDao.java 0 (0) x
        
        ReqAddSqlMapperDaoImpl.java 0 (0) x
        
        model 0 (0)
        
        ReqAddDTO.java 0 (0) x
        
        ReqAddSqlMaaperDTO.java 0 (0) x
        
        service 0 (0)
        
        ReqAdd.java 0 (0) x
        
        ReqAddImpl.java 0 (0) x
        
        ReqAddSqlMapper.java 0 (0) x
        
        ReqAddSqlMapperImpl.java 0 (0) x
      - module_reqchange 0 (0)
        
        controller 0 (0)
        
        AdminReqChangeController.java 0 (0) x
        
        AnonReqChangeController.java 0 (0) x
        
        UserReqChangeController.java 0 (0) x
        
        model 0 (0)
        
        ReqChangeDTO.java 0 (0) x
        
        service 0 (0)
        
        ReqChange.java 0 (0) x
        
        ReqChangeImpl.java 0 (0) x
      - module_reqreview 0 (0)
        
        controller 0 (0)
        
        AdminReqReviewController.java 0 (0) x
        
        AnonReqReviewController.java 0 (0) x
        
        UserReqReviewController.java 0 (0) x
        
        model 0 (0)
        
        ReqReviewDTO.java 0 (0) x
        
        service 0 (0)
        
        ReqReview.java 0 (0) x
        
        ReqReviewImpl.java 0 (0) x
      - module_reqspec 0 (0)
        
        controller 0 (0)
        
        AdminReqSpecController.java 0 (0) x
        
        AnonReqSpecController.java 0 (0) x
        
        UserReqSpecController.java 0 (0) x
        
        model 0 (0)
        
        ReqSpecDTO.java 0 (0) x
        
        service 0 (0)
        
        ReqSpec.java 0 (0) x
        
        ReqSpecImpl.java 0 (0) x
    - resources/egovframework/sqlmap/com/ext/jstree/springiBatis 0 (0)
      - moduleJSTF_SQL_Oracle_iBatis.xml 0 (0) x
  - pom.xml 0 (0) x
- pom.xml 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
admin	Author & Moderator
dongmin.lee	Reviewer - 0% reviewed
Total		0m	0

Linked Issue:
SP-313

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

SP-313 #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.10 1. 쓸데없는 모듈 클래스 삭제 2. 신규 버전 등록 시에 베이스 버전과 함께 신규 테이블 생성 하는 로직 추가 3. 이외 개발시 필요한 스키마 생성 컨트롤러 추가 4. 아이바티스 관련 코드 추가 5. 쿼리 관련 내용이 추가되었으나 PLSQL 관련 트리거는 동작하지 않는 문제가 남아있음. #close #time 1h

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/web-module/.../controller/AdminAnalCrawlerController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalCrawlerController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalCrawlerController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/AnalCrawlerDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalCrawler.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalCrawlerImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminAnalPdHeatmapController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalPdHeatmapController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalPdHeatmapController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../model/AnalPdHeatmapDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalPdHeatmap.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalPdHeatmapImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminAnalPdMemberController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalPdMemberController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalPdMemberController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/AnalPdMemberDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalPdMember.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalPdMemberImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminAnalPdReleaseController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalPdReleaseController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalPdReleaseController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../model/AnalPdReleaseDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalPdRelease.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalPdReleaseImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminAnalReportController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalReportController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalReportController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/AnalReportDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalReport.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalReportImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminAnalReqJiraController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalReqJiraController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalReqJiraController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/AnalReqJiraDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalReqJira.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalReqJiraImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminAnalReqRoleController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonAnalReqRoleController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserAnalReqRoleController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/AnalReqRoleDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/AnalReqRole.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/AnalReqRoleImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserPdServiceController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminReqAddController.java Added FishEye View File History Download Raw File File Annotation #permalink
Click to load diff

/web-module/.../controller/AnonReqAddController.java Added FishEye View File History Download Raw File File Annotation #permalink
Click to load diff

/web-module/.../controller/UserReqAddController.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../dao/ReqAddSqlMapperDao.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../dao/ReqAddSqlMapperDaoImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../model/ReqAddDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/ReqAddSqlMaaperDTO.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/ReqAdd.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/ReqAddImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/ReqAddSqlMapper.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/ReqAddSqlMapperImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminReqChangeController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonReqChangeController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserReqChangeController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/ReqChangeDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/ReqChange.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/ReqChangeImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AdminReqReviewController.java Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AnonReqReviewController.java Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/UserReqReviewController.java Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../model/ReqReviewDTO.java Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/ReqReview.java Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/ReqReviewImpl.java Deleted FishEye View File History File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/AdminReqSpecController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/AnonReqSpecController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../controller/UserReqSpecController.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/ReqSpecDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/ReqSpec.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../service/ReqSpecImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../springiBatis/moduleJSTF_SQL_Oracle_iBatis.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-3549

[SP-313] #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.10 1. 쓸데없는 모듈 클래스 삭제 2. 신규 버전 등록 시에 베이스 버전과 함께...

SR-3549 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[SP-313] #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.10 1. 쓸데없는 모듈 클래스 삭제 2. 신규 버전 등록 시에 베이스 버전과 함께...

SR-3549 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against