Evaluation license expires Wed Dec 31 22:00:00 KST 2098
open for 22 months | due 22 months ago

[SP-313] #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.21 아무리 바쁘고, 진도가 급해도 차근차근 진행하기 위하여, 전체적인 리팩토링을...

SR-3607

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author & Moderator      
Reviewer - 0% reviewed      
Total   0m 0  
#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.






SP-313 #comment Requirement 카테고리 :: 등록관리 메뉴 :: 22.11.21 아무리 바쁘고, 진도가 급해도 차근차근 진행하기 위하여, 전체적인 리팩토링을 진행. 리팩토링을 진행하며 세워진 기준은 ARMS_README에 기록함. #close #time 1h

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

There are no general comments on this review.
/web-module/.../batch/DashboardListBatch.java Deleted
Open in IDE #permalink
/web-module/.../batch/DashboardListConst.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonymousDashboardListController.java Deleted
Open in IDE #permalink
/web-module/.../service/DashboardListService.java Deleted
Open in IDE #permalink
/web-module/.../service/DashboardListServiceImpl.java Deleted
Open in IDE #permalink
/web-module/.../batch/DataSourceListBatch.java Deleted
Open in IDE #permalink
/web-module/.../batch/DataSourceListConst.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonymousDataSourceListController.java Deleted
Open in IDE #permalink
/web-module/.../service/DataSourceListService.java Deleted
Open in IDE #permalink
/web-module/.../service/DataSourceListServiceImpl.java Deleted
Open in IDE #permalink
/web-module/src/.../vo/DataSourceListDTO.java Deleted
Open in IDE #permalink
/web-module/src/.../batch/DeviceListBatch.java Deleted
Open in IDE #permalink
/web-module/.../controller/AdminDeviceListController.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonymousDeviceListController.java Deleted
Open in IDE #permalink
/web-module/.../controller/RestDeviceListController.java Deleted
Open in IDE #permalink
/web-module/.../controller/UserDeviceListController.java Deleted
Open in IDE #permalink
/web-module/.../service/DeviceListService.java Deleted
Open in IDE #permalink
/web-module/.../service/DeviceListServiceImpl.java Deleted
Open in IDE #permalink
/web-module/src/.../vo/DeviceListDTO.java Deleted
Open in IDE #permalink
/web-module/.../controller/JiraProjectCrawlerController.java Deleted
Open in IDE #permalink
/web-module/.../controller/AdminMenuController.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonymousMenuController.java Deleted
Open in IDE #permalink
/web-module/.../controller/RestMenuController.java Deleted
Open in IDE #permalink
/web-module/.../controller/UserMenuController.java Deleted
Open in IDE #permalink
/web-module/src/.../service/MenuService.java Deleted
Open in IDE #permalink
/web-module/.../service/MenuServiceImpl.java Deleted
Open in IDE #permalink
/web-module/src/main/.../menu/vo/MenuDTO.java Deleted
Open in IDE #permalink
/web-module/.../controller/AdminArmsMakerController.java Added
Open in IDE #permalink
/web-module/.../controller/AnonArmsMakerController.java Added
Open in IDE #permalink
/web-module/.../controller/UserArmsMakerController.java Added
Open in IDE #permalink
/web-module/.../dao/ArmsInstallSqlMapperDao.java Added
Open in IDE #permalink
/web-module/.../dao/ArmsInstallSqlMapperDaoImpl.java Added
Open in IDE #permalink
/web-module/.../model/ArmsInstallDB_SqlMaaperDTO.java Added
Open in IDE #permalink
/web-module/src/.../model/ArmsMakerDTO.java Added
Open in IDE #permalink
/web-module/src/.../service/ArmsInstallDB.java Added
Open in IDE #permalink
/web-module/src/.../service/ArmsMaker.java Added
Open in IDE #permalink
/web-module/src/.../service/ArmsMakerImpl.java Added
Open in IDE #permalink
/web-module/.../service/FileRepositoryInstallDBImpl.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceInstallDBImpl.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceVersionInstallDBImpl.java Added
Open in IDE #permalink
/web-module/.../controller/AdminFileRepositoryLogController.java Added
Open in IDE #permalink
/web-module/.../controller/AnonFileRepositoryLogController.java Added
Open in IDE #permalink
/web-module/.../controller/UserFileRepositoryLogController.java Added
Open in IDE #permalink
/web-module/.../model/FileRepositoryLogDTO.java Added
Open in IDE #permalink
/web-module/.../service/FileRepositoryLog.java Added
Open in IDE #permalink
/web-module/.../service/FileRepositoryLogImpl.java Added
Open in IDE #permalink
/web-module/.../controller/AdminPdJiraController.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonPdJiraController.java Deleted
Open in IDE #permalink
/web-module/.../controller/UserPdJiraController.java Deleted
Open in IDE #permalink
/web-module/src/.../model/PdJiraDTO.java Deleted
Open in IDE #permalink
/web-module/src/.../service/PdJira.java Deleted
Open in IDE #permalink
/web-module/src/.../service/PdJiraImpl.java Deleted
Open in IDE #permalink
/web-module/.../controller/AdminPdMapperController.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonPdMapperController.java Deleted
Open in IDE #permalink
/web-module/.../controller/UserPdMapperController.java Deleted
Open in IDE #permalink
/web-module/src/.../model/PdMapperDTO.java Deleted
Open in IDE #permalink
/web-module/src/.../service/PdMapper.java Deleted
Open in IDE #permalink
/web-module/src/.../service/PdMapperImpl.java Deleted
Open in IDE #permalink
/web-module/.../controller/AdminPdServiceController.java Changed
Open in IDE #permalink
/web-module/.../controller/AnonPdServiceController.java Changed
Open in IDE #permalink
/web-module/.../controller/UserPdServiceController.java Changed
/web-module/src/.../model/PdServiceDTO.java Changed
/web-module/src/.../service/PdService.java Changed
/web-module/src/.../service/PdServiceImpl.java Changed
/web-module/.../controller/AdminPdServiceConnectLogController.java Added
Open in IDE #permalink
/web-module/.../controller/AnonPdServiceConnectLogController.java Added
Open in IDE #permalink
/web-module/.../controller/UserPdServiceConnectLogController.java Added
Open in IDE #permalink
/web-module/.../model/PdServiceConnectLogDTO.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceConnectLog.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceConnectLogImpl.java Added
Open in IDE #permalink
/web-module/.../model/PdServiceJiraDTO.java Changed
/web-module/.../controller/AdminPdServiceJiraLogController.java Added
Open in IDE #permalink
/web-module/.../controller/AnonPdServiceJiraLogController.java Added
Open in IDE #permalink
/web-module/.../controller/UserPdServiceJiraLogController.java Added
Open in IDE #permalink
/web-module/.../model/PdServiceJiraLogDTO.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceJiraLog.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceJiraLogImpl.java Added
Open in IDE #permalink
/web-module/.../controller/UserPdServiceLogController.java Changed
/web-module/.../controller/AdminPdServiceVersionController.java Added
Open in IDE #permalink
/web-module/.../controller/AnonPdServiceVersionController.java Added
Open in IDE #permalink
/web-module/.../controller/UserPdServiceVersionController.java Added
Open in IDE #permalink
/web-module/.../model/PdServiceVersionDTO.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceVersion.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceVersionImpl.java Added
Open in IDE #permalink
/web-module/.../controller/AdminPdServiceVersionLogController.java Added
Open in IDE #permalink
/web-module/.../controller/AnonPdServiceVersionLogController.java Added
Open in IDE #permalink
/web-module/.../controller/UserPdServiceVersionLogController.java Added
Open in IDE #permalink
/web-module/.../model/PdServiceVersionLogDTO.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceVersionLog.java Added
Open in IDE #permalink
/web-module/.../service/PdServiceVersionLogImpl.java Added
Open in IDE #permalink
/web-module/.../controller/AdminPdVersionController.java Deleted
Open in IDE #permalink
/web-module/.../controller/AnonPdVersionController.java Deleted
Open in IDE #permalink
/web-module/.../controller/UserPdVersionController.java Deleted
Open in IDE #permalink
/web-module/src/.../model/PdVersionDTO.java Deleted
Open in IDE #permalink
/web-module/src/.../service/PdVersion.java Deleted
Open in IDE #permalink
/web-module/src/.../service/PdVersionImpl.java Deleted
Open in IDE #permalink
/web-module/.../controller/UserReqAddLogController.java Changed
/web-module/.../springiBatis/aRMS_FileRepository_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/aRMS_PdServiceConnect_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/aRMS_PdServiceJira_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/aRMS_PdServiceVersion_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/aRMS_PdService_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/aRMS_ReqAdd_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/aRMS_ReqAdd_Template_SQL_Oracle_iBatis.xml Added
Open in IDE #permalink
/web-module/.../springiBatis/moduleJSTF_SQL_Oracle_iBatis.xml Deleted
Open in IDE #permalink
/web-module/.../arms/AnalCrawler_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalPdHeatmap_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalPdMember_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalPdRelease_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalReport_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalReqJira_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalReqRole_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/DeviceList_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/src/.../arms/Menu_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/Monitor_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/src/.../arms/PdJira_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/PdMapper_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/PdService_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/PdVersion_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/ReqChange_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/ReqReview_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/ReqSpec_Oracle_DDL.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalCrawler_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalPdHeatmap_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalPdMember_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalPdRelease_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalReport_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalReqJira_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/AnalReqRole_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/DeviceList_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/src/.../arms/Menu_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/Monitor_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/src/.../arms/PdJira_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/PdMapper_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/PdService_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/PdVersion_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/ReqChange_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/ReqReview_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/.../arms/ReqSpec_Oracle_DML.sql Deleted
Open in IDE #permalink
/web-module/pom.xml Changed
/aRMS_README.md Added
Open in IDE #permalink
/pom.xml Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create Issue

X
Assign To Me

Log time against