SR-3609 [SP-313] #comment JSTF 전체 리팩토링 DTO 를 정형타입으로 변경 SQL Mapper를 활용한 동적 테이블 생성 #close #time 1h

open for 25 months | due 25 months ago

[SP-313] #comment JSTF 전체 리팩토링 DTO 를 정형타입으로 변경 SQL Mapper를 활용한 동적 테이블 생성 #close #time 1h

Author

Moderator

Reviewers

Details
Objectives
General Comments 0 (0)
Number of files included: 35

jsTreeServiceFrameworkBackendAppRepo 0 (0)
- web-module 0 (0)
  - src/main 0 (0)
    - java/egovframework/api/arms 0 (0)
      - module_armsmaker 0 (0)
        
        controller 0 (0)
        
        UserArmsMakerController.java 0 (0) x
        
        service 0 (0)
        
        ArmsInstallDB.java 0 (0) x
        
        FileRepositoryInstallDBImpl.java 0 (0) x
        
        PdServiceConnectInstallDBImpl.java 0 (0) x
        
        PdServiceInstallDBImpl.java 0 (0) x
        
        PdServiceJiraInstallDBImpl.java 0 (0) x
        
        PdServiceVersionInstallDBImpl.java 0 (0) x
        
        ReqAddTemplateInstallDBImpl.java 0 (0) x
      - module_filerepository/model 0 (0)
        
        FileRepositoryDTO.java 0 (0) x
      - module_filerepositorylog/model 0 (0)
        
        FileRepositoryLogDTO.java 0 (0) x
      - module_pdservice/controller 0 (0)
        
        UserPdServiceController.java 0 (0) x
      - module_pdserviceconnect/model 0 (0)
        
        PdServiceConnectDTO.java 0 (0) x
      - module_pdserviceconnectlog/model 0 (0)
        
        PdServiceConnectLogDTO.java 0 (0) x
      - module_pdservicejira/model 0 (0)
        
        PdServiceJiraDTO.java 0 (0) x
      - module_pdservicejiralog/model 0 (0)
        
        PdServiceJiraLogDTO.java 0 (0) x
      - module_pdservicelog/model 0 (0)
        
        PdServiceLogDTO.java 0 (0) x
      - module_pdserviceversion/model 0 (0)
        
        PdServiceVersionDTO.java 0 (0) x
      - module_pdserviceversionlog/model 0 (0)
        
        PdServiceVersionLogDTO.java 0 (0) x
      - module_reqadd 0 (0)
        
        controller 0 (0)
        
        UserReqAddController.java 0 (0) x
        
        dao 0 (0)
        
        ReqAddSqlMapperDao.java 0 (0) x
        
        ReqAddSqlMapperDaoImpl.java 0 (0) x
        
        model 0 (0)
        
        ReqAddDTO.java 0 (0) x
        
        ReqAddSqlMaaperDTO.java 0 (0) x
        
        service 0 (0)
        
        ReqAddSqlMapper.java 0 (0) x
        
        ReqAddSqlMapperImpl.java 0 (0) x
      - module_reqaddlog/model 0 (0)
        
        ReqAddLogDTO.java 0 (0) x
    - resources/egovframework/sqlmap 0 (0)
      - com/ext/jstree/springiBatis 0 (0)
        
        aRMS_FileRepository_SQL_Oracle_iBatis.xml 0 (0) x
        
        aRMS_PdServiceConnect_SQL_Oracle_iBatis.xml 0 (0) x
        
        aRMS_PdServiceJira_SQL_Oracle_iBatis.xml 0 (0) x
        
        aRMS_PdServiceVersion_SQL_Oracle_iBatis.xml 0 (0) x
        
        aRMS_PdService_SQL_Oracle_iBatis.xml 0 (0) x
        
        aRMS_ReqAdd_SQL_Oracle_iBatis.xml 0 (0) x
        
        aRMS_ReqAdd_Template_SQL_Oracle_iBatis.xml 0 (0) x
      - config/oracle 0 (0)
        
        sql-map-config-oracle-ext-arms.xml 0 (0) x
  - pom.xml 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
admin	Author & Moderator
dongmin.lee	Reviewer - 0% reviewed
Total		0m	0

Linked Issue:
SP-313

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

SP-313 #comment JSTF 전체 리팩토링 DTO 를 정형타입으로 변경 SQL Mapper를 활용한 동적 테이블 생성 #close #time 1h

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/web-module/.../controller/UserArmsMakerController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../service/ArmsInstallDB.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/FileRepositoryInstallDBImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/PdServiceConnectInstallDBImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/PdServiceInstallDBImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/PdServiceJiraInstallDBImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/PdServiceVersionInstallDBImpl.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../service/ReqAddTemplateInstallDBImpl.java Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/FileRepositoryDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/FileRepositoryLogDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/UserPdServiceController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/PdServiceConnectDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/PdServiceConnectLogDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/PdServiceJiraDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/PdServiceJiraLogDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/src/.../model/PdServiceLogDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/PdServiceVersionDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/PdServiceVersionLogDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../controller/UserReqAddController.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../dao/ReqAddSqlMapperDao.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../dao/ReqAddSqlMapperDaoImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/ReqAddDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../model/ReqAddSqlMaaperDTO.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/ReqAddSqlMapper.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/.../service/ReqAddSqlMapperImpl.java Deleted FishEye View File History #permalink
Click to load diff

/web-module/src/.../model/ReqAddLogDTO.java Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_FileRepository_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_PdServiceConnect_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_PdServiceJira_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_PdServiceVersion_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_PdService_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_ReqAdd_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../springiBatis/aRMS_ReqAdd_Template_SQL_Oracle_iBatis.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

/web-module/.../oracle/sql-map-config-oracle-ext-arms.xml Added FishEye View File History Download Raw File File Annotation File Outdated View Latest #permalink
Click to load diff

/web-module/pom.xml Changed FishEye View File History Download Raw File File Annotation File Diff File Outdated View Latest #permalink
Click to load diff

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-3609

[SP-313] #comment JSTF 전체 리팩토링 DTO 를 정형타입으로 변경 SQL Mapper를 활용한 동적 테이블 생성 #close #time 1h

SR-3609 0 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[SP-313] #comment JSTF 전체 리팩토링 DTO 를 정형타입으로 변경 SQL Mapper를 활용한 동적 테이블 생성 #close #time 1h

SR-3609 0 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against