SR-814 [PROJECT-WAR][1.0.0-SNAPSHOT][이동민] [BT] SP-7 #resolve #time 1h #comment sitemesh 설정을 변경하여 폴더 구조를 미려하게...

closed on 13 Nov 15

[PROJECT-WAR][1.0.0-SNAPSHOT][이동민] [BT] SP-7 #resolve #time 1h #comment sitemesh 설정을 변경하여 폴더 구조를 미려하게...

Author

Moderator

Reviewers

Details
Objectives
General Comments 0 (0)
Number of files included: 34

standardSvn (root:) 0 (0)
- development-standard/standard-projects/project-war/src/main/webapp/WEB-INF 0 (0)
  - jsp 0 (0)
    - community/account/secure 0 (0)
      - accountSign.jsp 1 (0) x
    - sitemesh 0 (0)
      - adminFooter.jsp 0 (0) x
      - adminHeader.jsp 0 (0) x
      - adminNavigation.jsp 0 (0) x
      - footer.jsp 0 (0) x
      - header.jsp 0 (0) x
      - navigation.jsp 0 (0) x
      - navigation.jsp.without.jstree 0 (0) x
      - no-display.jsp 0 (0) x
      - script.jsp 0 (0) x
      - style.jsp 0 (0) x
    - account 0 (0) x
  - sitemesh 0 (0)
    - jsp 0 (0) x
      - adminDeco.jsp 0 (0) x
      - adminFooter.jsp 0 (0) x
      - adminHeader.jsp 0 (0) x
      - adminNavigation.jsp 0 (0) x
      - bodyPanel.jsp 0 (0) x
      - defaultDeco.jsp 0 (0) x
      - footer.jsp 0 (0) x
      - headPanel.jsp 0 (0) x
      - header.jsp 0 (0) x
      - navigation.jsp 0 (0) x
      - navigation.jsp.without.jstree 0 (0) x
      - no-display.jsp 0 (0) x
      - popupDeco.jsp 0 (0) x
      - script.jsp 0 (0) x
      - style.jsp 0 (0) x
    - adminDeco.jsp 0 (0) x
    - bodyPanel.jsp 0 (0) x
    - decorators.xml 0 (0) x
    - defaultDeco.jsp 0 (0) x
    - headPanel.jsp 0 (0) x
    - popupDeco.jsp 0 (0) x

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
admin	Author & Moderator	7m
spear79 (deleted user)	Reviewer - Complete	1m
sonhoseong (deleted user)	Reviewer - Complete	1m	1	이건뭔가요? 의미없는 주석같은데요?
Total		8m	1

Linked Issue:
SP-7

#permalink

Objectives

코드리뷰는 코드를 통해 소통하고, 서로의 경험을 통해 배우면서 성장 할 수 있는 기회입니다.
나를 위해, 나의 동료를 위해, 우리 팀을 위해 리뷰 시간을 사용해 주세요.
리뷰를 통해 발견한 흥미로운 코드, 좋은 설계 등을 활발하게 공유하십시요.

•너무 많은 코드를 한꺼번에 리뷰하지 마세요.
•최소한의 설명과 함께 중점적으로 봐야 할 곳을 알려 주세요.
•리뷰 후 Comment를 남겨 주세요.
•리뷰는 빠른 시간에 응답해 주세요.
•지적 보다는 대안을 제시해 주세요.

[PROJECT-WAR][1.0.0-SNAPSHOT][이동민]
[BT] SP-7 #resolve #time 1h #comment sitemesh 설정을 변경하여 폴더 구조를 미려하게 변경함.
[RV]

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

/development-standard/.../secure/accountSign.jsp Changed 1 (0) FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/development-standard/.../sitemesh/adminFooter.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/adminHeader.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/adminNavigation.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/footer.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/header.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/navigation.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/navigation.jsp.without.jstree Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/no-display.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/script.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/style.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../jsp/account/ Added FishEye View File History #permalink
Repository standardSvn does not exist

/development-standard/.../sitemesh/jsp/ Added FishEye View File History #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/adminDeco.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/adminFooter.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/adminHeader.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/adminNavigation.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/bodyPanel.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/defaultDeco.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/footer.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/development-standard/.../jsp/headPanel.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/development-standard/.../jsp/header.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/development-standard/.../jsp/navigation.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/navigation.jsp.without.jstree Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/no-display.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/popupDeco.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/script.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../jsp/style.jsp Moved FishEye View File History Download Raw File File Annotation File Diff #permalink
Repository standardSvn does not exist

/development-standard/.../sitemesh/adminDeco.jsp Deleted FishEye View File History #permalink
Repository standardSvn does not exist

/development-standard/.../sitemesh/bodyPanel.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/decorators.xml Changed FishEye View File History Download Raw File File Annotation File Diff #permalink
Click to load diff

/development-standard/.../sitemesh/defaultDeco.jsp Deleted FishEye View File History #permalink
Click to load diff

/development-standard/.../sitemesh/headPanel.jsp Deleted FishEye View File History #permalink
Repository standardSvn does not exist

/development-standard/.../sitemesh/popupDeco.jsp Deleted FishEye View File History #permalink
Repository standardSvn does not exist

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=FE}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

SR-814

[PROJECT-WAR][1.0.0-SNAPSHOT][이동민] [BT] SP-7 #resolve #time 1h #comment sitemesh 설정을 변경하여 폴더 구조를 미려하게...

SR-814 1 (0)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against

[PROJECT-WAR][1.0.0-SNAPSHOT][이동민] [BT] SP-7 #resolve #time 1h #comment sitemesh 설정을 변경하여 폴더 구조를 미려하게...

SR-814 1 (0)

Summarize the review outcomes (optional)

Details

Objectives

Issues Raised From Comments

General Comments

Create Issue

Log time against